[SPARK-23794][SQL] Make UUID as stateful expression #20912
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @hvanhovell |
hvanhovell
approved these changes
Mar 27, 2018
Contributor
hvanhovell
left a comment
hvanhovell
left a comment
There was a problem hiding this comment.
LGTM - pending jenkins
|
Test build #88625 has finished for PR 20912 at commit
|
Contributor
|
Merging to master. Thanks for the quick turnaround! |
Contributor
Member
Author
|
Seems it didn't show up in github's commit? |
Contributor
|
The workflow is that we merge to apache git, and that the commit get pushed to github via some synchronization. Apparently the latter is broken. |
Contributor
|
wow that only took 8 hours.... |
mshtelma
pushed a commit
to mshtelma/spark
that referenced
this pull request
Apr 5, 2018
## What changes were proposed in this pull request? The UUID() expression is stateful and should implement the `Stateful` trait instead of the `Nondeterministic` trait. ## How was this patch tested? Added test. Author: Liang-Chi Hsieh <viirya@gmail.com> Closes apache#20912 from viirya/SPARK-23794.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The UUID() expression is stateful and should implement the
Statefultrait instead of theNondeterministictrait.How was this patch tested?
Added test.