[SPARK-24323][SQL] Fix lint-java errors #21374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #90842 has finished for PR 21374 at commit
|
Member
|
Jenkins, retest this please |
|
Test build #90843 has finished for PR 21374 at commit
|
Member
|
Hi, @kiszk and @felixcheung . |
Member
Author
|
@dongjoon-hyun thank you, l will kick this later. |
Member
Author
|
retest this please |
|
Test build #90851 has finished for PR 21374 at commit
|
Member
Author
Member
|
hm, I think we better fix these in a batch or when the release is close ... |
Member
Author
|
Until now, @gatorsmile and @ueshin fixed these when we found. I am neutral on the policy. |
Member
|
Yea, so I am saying that we probably do this less frequently. LGTM btw if it fixes. No reason to block it. |
HyukjinKwon
approved these changes
May 21, 2018
Member
|
Also, I don't think we need a JIRA for each lint break. It's "virtually same" before after. |
Member
|
Merged to master |
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Mar 7, 2019
## What changes were proposed in this pull request? This PR fixes the following errors reported by `lint-java` ``` % dev/lint-java Using `mvn` from path: /usr/bin/mvn Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartition.java:[39] (sizes) LineLength: Line is longer than 100 characters (found 104). [ERROR] src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartitionReader.java:[26] (sizes) LineLength: Line is longer than 100 characters (found 110). [ERROR] src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartitionReader.java:[30] (sizes) LineLength: Line is longer than 100 characters (found 104). ``` ## How was this patch tested? Run `lint-java` manually. Author: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Closes apache#21374 from kiszk/SPARK-24323. (cherry picked from commit e480ecc)
rdblue
pushed a commit
to rdblue/spark
that referenced
this pull request
Apr 3, 2019
This PR fixes the following errors reported by `lint-java` ``` % dev/lint-java Using `mvn` from path: /usr/bin/mvn Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartition.java:[39] (sizes) LineLength: Line is longer than 100 characters (found 104). [ERROR] src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartitionReader.java:[26] (sizes) LineLength: Line is longer than 100 characters (found 110). [ERROR] src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartitionReader.java:[30] (sizes) LineLength: Line is longer than 100 characters (found 104). ``` Run `lint-java` manually. Author: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Closes apache#21374 from kiszk/SPARK-24323.
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Oct 15, 2019
## What changes were proposed in this pull request? This PR fixes the following errors reported by `lint-java` ``` % dev/lint-java Using `mvn` from path: /usr/bin/mvn Checkstyle checks failed at following occurrences: [ERROR] src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartition.java:[39] (sizes) LineLength: Line is longer than 100 characters (found 104). [ERROR] src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartitionReader.java:[26] (sizes) LineLength: Line is longer than 100 characters (found 110). [ERROR] src/main/java/org/apache/spark/sql/sources/v2/reader/InputPartitionReader.java:[30] (sizes) LineLength: Line is longer than 100 characters (found 104). ``` ## How was this patch tested? Run `lint-java` manually. Author: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Closes apache#21374 from kiszk/SPARK-24323. (cherry picked from commit e480ecc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the following errors reported by
lint-javaHow was this patch tested?
Run
lint-javamanually.