[Spark-24376][doc]Summary:compiling spark with scala-2.10 should use the -P parameter instead of -D #21422
Conversation
git config --global user.name "gentlewangyu"
|
I have verified this patch |
docs/building-spark.md
Outdated
|
|
||
| ./dev/change-scala-version.sh 2.10 | ||
| ./build/mvn -Pyarn -Dscala-2.10 -DskipTests clean package | ||
| ./build/mvn -Pyarn -scala-2.10 -DskipTestsP clean package |
|
Minor fix doesn't usually need a JIRA. Let's avoid next time. |
|
ok to test |
|
Test build #91137 has finished for PR 21422 at commit
|
|
@HyukjinKwon thanks for your answer!
|
|
Why do you submit PR against branch 2.2? Besides scala-2.10 profile is no longer valid after 2.3. |
|
But isn't it still a valid fix for 2.2.x? |
|
Yes, but the PR should be against master branch. |
|
And in master/Spark 2.3 code, since we don't support Scala 2.10, instead we support 2.12, so we should change that part of doc accordingly. |
|
Seems this paragraph is already removed in master branch (https://issues.apache.org/jira/browse/SPARK-19810). So this is a branch 2.2- issue only. |
|
Do we still have a 2.2 release? If not, then this fix seems obsolete. |
|
I don't know but the fix is open anyway and I thought we better just merge it since it's a valid fix to branch-2.3 anyway and there's no downside of it for example like making the backport harder or since the bit is removed in the master, or potential concern of new bug in this branch alone since it's just doc fix basically. PR size is small. I got that we don't usually fix things in a specific branch alone but this one seems fine. |
|
It is not valid for branch-2.3, 2.3 already removed the support of Scala 2.10. |
|
Oops, I meant branch-2.2. |
|
There was a similar(?) argument before - #18873 (comment), FYI. @gentlewangyu, let's just close this then. The gain is small anyway. |
|
@HyukjinKwon @jerryshao ok , thanks |
|
Thank you @gentlewangyu. |
4 participants
What changes were proposed in this pull request?
compiling spark with scala-2.10 should use the -P parameter instead of -D
How was this patch tested?
JIRA_ID:SPARK-24376
using build/mvn clean package install deploy -DskipTests -Pscala-2.10
Please review http://spark.apache.org/contributing.html before opening a pull request.