Skip to content

Conversation

@viirya
Copy link
Member

@viirya viirya commented Aug 27, 2014

According to the text message, both relations should be tested. So add the missing condition.

@viirya viirya changed the title [SPARK-3252] Add missing condition for test [SPARK-3252][SQL] Add missing condition for test Aug 27, 2014
@marmbrus
Copy link
Contributor

ok to test

@marmbrus
Copy link
Contributor

/cc @concretevitamin

@SparkQA
Copy link

SparkQA commented Aug 27, 2014

QA tests have started for PR 2159 at commit b1c0f52.

  • This patch merges cleanly.

@concretevitamin
Copy link
Contributor

This is not harmful yet it doesn't do anything either, since in the test
query the two relations should be the same.

On Wednesday, August 27, 2014, Michael Armbrust notifications@github.com
wrote:

/cc @concretevitamin https://github.com/concretevitamin


Reply to this email directly or view it on GitHub
#2159 (comment).

@SparkQA
Copy link

SparkQA commented Aug 27, 2014

QA tests have finished for PR 2159 at commit b1c0f52.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Aug 27, 2014
According to the text message, both relations should be tested. So add the missing condition.

Author: viirya <viirya@gmail.com>

Closes #2159 from viirya/fix_test and squashes the following commits:

b1c0f52 [viirya] add missing condition.

(cherry picked from commit 28d41d6)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in 28d41d6 Aug 27, 2014
@marmbrus
Copy link
Contributor

Thanks! I've merged this to master and 1.1.

xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
According to the text message, both relations should be tested. So add the missing condition.

Author: viirya <viirya@gmail.com>

Closes apache#2159 from viirya/fix_test and squashes the following commits:

b1c0f52 [viirya] add missing condition.
@viirya viirya deleted the fix_test branch December 27, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants