[SPARK-24800][SQL] Refactor Avro Serializer and Deserializer #21762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #92975 has finished for PR 21762 at commit
|
cloud-fan
reviewed
Jul 14, 2018
| def deserialize(data: Any): Any = converter(data) | ||
|
|
||
| /** | ||
| * Creates a writer to writer avro values to Catalyst values at the given ordinal with the given |
| def setInt(ordinal: Int, value: Int): Unit = set(ordinal, value) | ||
| def setLong(ordinal: Int, value: Long): Unit = set(ordinal, value) | ||
| def setDouble(ordinal: Int, value: Double): Unit = set(ordinal, value) | ||
| def setFloat(ordinal: Int, value: Float): Unit = set(ordinal, value) |
Contributor
There was a problem hiding this comment.
seems we don't need these default implementation
| * This function takes an avro schema and returns a sql schema. | ||
| */ | ||
| def toSqlType(avroSchema: Schema): SchemaType = { | ||
| def toCatalystType(avroSchema: Schema): SchemaType = { |
Contributor
There was a problem hiding this comment.
maybe we don't need to rename it?
|
Test build #93026 has finished for PR 21762 at commit
|
Contributor
|
thanks, merging to master! |
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
Currently the Avro Deserializer converts input Avro format data to `Row`, and then convert the `Row` to `InternalRow`. While the Avro Serializer converts `InternalRow` to `Row`, and then output Avro format data. This PR allows direct conversion between `InternalRow` and Avro format data. Unit test Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21762 from gengliangwang/avro_io. (cherry picked from commit 9603087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently in Avro data source module
Row, and then convert theRowtoInternalRow.InternalRowtoRow, and then output Avro format data.This PR allows direct conversion between
InternalRowand Avro format data.How was this patch tested?
Unit test