[SPARK-24846][SQL] Made hashCode ExprId independent of jvmId #21806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ok to test |
Contributor
|
@gvr can you clean-up the description somewhat? It currently also has part of the template in it. |
Contributor
|
otherwise, LGTM pending jenkins |
Contributor
Author
|
Updated description, thanks @hvanhovell |
|
Test build #93240 has finished for PR 21806 at commit
|
Member
|
The change looks fine. However I'm wondering that have we had chance to compare hash code between expr ids from different jvms? |
Contributor
|
@viirya this current change is only useful when you compare canonicalized plans created on different JVMs. This has come up when we tried to detect changes in plans over spark versions (plan stability) and when people are writing to caches used by multiple clusters. |
Member
|
@hvanhovell Got it. Thanks for your explanation. LGTM. |
Member
|
LGTM too |
Contributor
|
Merging to master. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Made ExprId hashCode independent of jvmId to make canonicalization independent of JVM, by overriding hashCode (and necessarily also equality) to depend on id only
How was this patch tested?
Created a unit test ExprIdSuite
Ran all unit tests of sql/catalyst