[SPARK-24868][PYTHON]add sequence function in Python #21820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #93303 has finished for PR 21820 at commit
|
HyukjinKwon
approved these changes
Jul 20, 2018
python/pyspark/sql/functions.py
Outdated
| @since(2.4) | ||
| def sequence(start, stop, step=None): | ||
| """ | ||
| Generate a sequence of integers from start to stop, incrementing by step. |
Member
There was a problem hiding this comment.
Let's quite them `start` and `stop`
| >>> df1 = spark.createDataFrame([(-2, 2)], ('C1', 'C2')) | ||
| >>> df1.select(sequence('C1', 'C2').alias('r')).collect() | ||
| [Row(r=[-2, -1, 0, 1, 2])] | ||
| >>> df2 = spark.createDataFrame([(4, -4, -2)], ('C1', 'C2', 'C3')) |
Member
There was a problem hiding this comment.
What happens if the step is positive in this case?
Contributor
Author
There was a problem hiding this comment.
It will throw java.lang.IllegalArgumentException.
There is a check in collectionOperations.scala
require(
(step > num.zero && start <= stop)
|| (step < num.zero && start >= stop)
|| (step == num.zero && start == stop),
s"Illegal sequence boundaries: $start to $stop by $step")
|
Test build #93317 has finished for PR 21820 at commit
|
Member
|
Merged to master |
Contributor
Author
|
@HyukjinKwon Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
sequencein functions.pyHow was this patch tested?
Add doctest.