[SPARK-24876][SQL] Avro: simplify schema serialization #21829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #93347 has finished for PR 21829 at commit
|
gatorsmile
reviewed
Jul 20, 2018
Member
There was a problem hiding this comment.
the naming is confusing. We have schema, avroJsonSchema and avroSchema. Also add comments about these variables.
gengliangwang
force-pushed
the
removeSerializableSchema
branch
from
f376503 to
bdf2f48
Compare
|
Test build #93355 has finished for PR 21829 at commit
|
Member
|
LGTM Thanks! Merged to master |
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
Previously in the refactoring of Avro Serializer and Deserializer, a new class SerializableSchema is created for serializing the Avro schema: https://github.com/apache/spark/pull/21762/files#diff-01fea32e6ec6bcf6f34d06282e08705aR37 On second thought, we can use `toString` method for serialization. After that, parse the JSON format schema on executor. This makes the code much simpler. Unit test Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21829 from gengliangwang/removeSerializableSchema. (cherry picked from commit 00b864a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Previously in the refactoring of Avro Serializer and Deserializer, a new class SerializableSchema is created for serializing the Avro schema:
https://github.com/apache/spark/pull/21762/files#diff-01fea32e6ec6bcf6f34d06282e08705aR37
On second thought, we can use
toStringmethod for serialization. After that, parse the JSON format schema on executor. This makes the code much simpler.How was this patch tested?
Unit test