Skip to content

[SPARK-24880][BUILD]Fix the group id for spark-kubernetes-integration-tests #21831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zsxwing wants to merge 2 commits into from
Closed

[SPARK-24880][BUILD]Fix the group id for spark-kubernetes-integration-tests #21831

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4345139
Fix the group id for spark-kubernetes-integration-tests
zsxwing Jul 20, 2018
980d30c
remove groupId
zsxwing Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion resource-managers/kubernetes/integration-tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
</parent>

<artifactId>spark-kubernetes-integration-tests_2.11</artifactId>
<groupId>spark-kubernetes-integration-tests</groupId>
Copy link
Member

@gatorsmile gatorsmile Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we need groupId ?

Copy link
Member Author

@zsxwing zsxwing Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we need groupId?

Yes. Each project must have a groupId and artifactId.

Copy link
Member Author

@zsxwing zsxwing Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. groupId can be ignored and it will inherit from the parent module. I just removed it.

<properties>
<download-maven-plugin.version>1.3.0</download-maven-plugin.version>
<exec-maven-plugin.version>1.4.0</exec-maven-plugin.version>
Expand Down