[SQL][HIVE] Correct an assert message in function makeRDDForTable #21836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to the context, "makeRDDForTablePartitions" in assert message should be "makeRDDForPartitionedTable"
Member
|
ok to test |
Member
|
test this please |
Member
|
retest this please |
|
Test build #93427 has finished for PR 21836 at commit
|
the line modified exceeds 100 characters, it leads to Scala style checks failure, cut it into two line to solve it.
HyukjinKwon
reviewed
Jul 23, 2018
|
|
||
| assert(!hiveTable.isPartitioned, """makeRDDForTable() cannot be called on a partitioned table, | ||
| since input formats may differ across partitions. Use makeRDDForTablePartitions() instead.""") | ||
| since input formats may differ across partitions. Use makeRDDForPartitionedTable() |
Member
There was a problem hiding this comment.
I think it's gonna keep the white spaces as is. Mind if I ask change this as below?
assert(
!hiveTable.isPartitioned,
"makeRDDForTable() cannot be called on a partitioned table, since input formats may differ " +
"across partitions. Use makeRDDForTablePartitions() instead."
Contributor
Author
There was a problem hiding this comment.
That's Good. I will modify it, thanks.
Member
|
test this please |
|
Test build #93432 has finished for PR 21836 at commit
|
Contributor
Author
|
I'm sorry for the scala style checks failure, i will read scala style guide doc again. |
Member
|
retest this please |
|
Test build #93434 has finished for PR 21836 at commit
|
Member
|
Merged to master and branch-2.3. |
asfgit
pushed a commit
that referenced
this pull request
Jul 23, 2018
## What changes were proposed in this pull request? according to the context, "makeRDDForTablePartitions" in assert message should be "makeRDDForPartitionedTable", because "makeRDDForTablePartitions" does't exist in spark code. ## How was this patch tested? unit tests Please review http://spark.apache.org/contributing.html before opening a pull request. Author: SongYadong <song.yadong1@zte.com.cn> Closes #21836 from SongYadong/assert_info_modify. (cherry picked from commit ab18b02) Signed-off-by: hyukjinkwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
according to the context, "makeRDDForTablePartitions" in assert message should be "makeRDDForPartitionedTable", because "makeRDDForTablePartitions" does't exist in spark code.
How was this patch tested?
unit tests
Please review http://spark.apache.org/contributing.html before opening a pull request.