[SPARK-24339][SQL] Prunes the unused columns from child of ScriptTransformation #21839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@gatorsmile @maropu This is the follow up PR for #21447, please have a look when you have time, thanks. |
|
Test build #93413 has finished for PR 21839 at commit
|
Member
|
Thanks for the work! I’ll review this in hours. |
Member
|
LGTM cc: @gatorsmile |
gatorsmile
reviewed
Jul 23, 2018
| case e @ Expand(_, _, child) if (child.outputSet -- e.references).nonEmpty => | ||
| e.copy(child = prunedChild(child, e.references)) | ||
| case s @ ScriptTransformation(_, _, _, child, _) | ||
| if (child.outputSet -- s.references).nonEmpty => |
Member
There was a problem hiding this comment.
Nit: two more spaces before if.
Member
|
@xuanyuanking Could you add an end-to-end test into ScriptTransformationSuite to verify the results? |
Member
Author
|
@gatorsmile Thanks for your advice, added ut in ScriptTransformationSuite. |
Member
|
LGTM |
|
Test build #93448 has finished for PR 21839 at commit
|
Member
|
Thanks! Merged to master. |
Member
Author
|
Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Modify the strategy in ColumnPruning to add a Project between ScriptTransformation and its child, this strategy can reduce the scan time especially in the scenario of the table has many columns.
How was this patch tested?
Add UT in ColumnPruningSuite and ScriptTransformationSuite.