[SPARK-24887][SQL]Avro: use SerializableConfiguration in Spark utils to deduplicate code #21846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #93441 has finished for PR 21846 at commit
|
gatorsmile
reviewed
Jul 23, 2018
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
LGTM
Thanks! Merged to master
otterc
pushed a commit
to linkedin/spark
that referenced
this pull request
Mar 22, 2023
… to deduplicate code To implement the method `buildReader` in `FileFormat`, it is required to serialize the hadoop configuration for executors. Previous spark-avro uses its own class `SerializableConfiguration` for the serialization. As now it is part of Spark, we can use SerializableConfiguration in Spark util to deduplicate the code. Unit test Author: Gengliang Wang <gengliang.wang@databricks.com> Closes apache#21846 from gengliangwang/removeSerializableConfiguration. (cherry picked from commit 08e315f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To implement the method
buildReaderinFileFormat, it is required to serialize the hadoop configuration for executors.Previous spark-avro uses its own class
SerializableConfigurationfor the serialization. As now it is part of Spark, we can use SerializableConfiguration in Spark util to deduplicate the code.How was this patch tested?
Unit test