Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Jul 24, 2018

What changes were proposed in this pull request?

Improvement IN predicate type mismatched message:

Mismatched columns:
[(, t, 4, ., `, t, 4, a, `, :, d, o, u, b, l, e, ,,  , t, 5, ., `, t, 5, a, `, :, d, e, c, i, m, a, l, (, 1, 8, ,, 0, ), ), (, t, 4, ., `, t, 4, c, `, :, s, t, r, i, n, g, ,,  , t, 5, ., `, t, 5, c, `, :, b, i, g, i, n, t, )]

After this patch:

Mismatched columns:
[(t4.`t4a`:double, t5.`t5a`:decimal(18,0)), (t4.`t4c`:string, t5.`t5c`:bigint)]

How was this patch tested?

unit tests

@gatorsmile
Copy link
Member

Could you add a test case?

@SparkQA
Copy link

SparkQA commented Jul 24, 2018

Test build #93506 has finished for PR 21863 at commit e455bda.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dilipbiswal
Copy link
Contributor

dilipbiswal commented Jul 24, 2018

@gatorsmile Hi sean, isn't @mgaido91 working in the same area with the in subq pr ? Or its a different scenario ?

@gatorsmile
Copy link
Member

@dilipbiswal This PR is to fix a message. It is nice to have.

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dilipbiswal
Copy link
Contributor

@gatorsmile Got it. Thank you.

@SparkQA
Copy link

SparkQA commented Jul 25, 2018

Test build #93529 has finished for PR 21863 at commit e55d700.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

Thanks! Merged to master.

@asfgit asfgit closed this in 7a5fd4a Jul 25, 2018
@mgaido91
Copy link
Contributor

a late LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants