[SPARK-24919][BUILD] New linter rule for sparkContext.hadoopConfiguration #21873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxin
reviewed
Jul 25, 2018
| </check> | ||
|
|
||
| <check customId="hadoopconfiguration" level="error" class="org.scalastyle.file.RegexChecker" enabled="true"> | ||
| <parameters><parameter name="regex">spark(.sqlContext)?.sparkContext.hadoopConfiguration</parameter></parameters> |
Contributor
There was a problem hiding this comment.
can we just match on hadoopConfiguration ?
Member
Author
There was a problem hiding this comment.
I think that would be tricky:
- In core module the function
spark.sessionState.newHadoopConf()can't be accessed. - Run
find . -name *.scala|xargs grep hadoopConfiguration |wc -land there are 100 appearances.
Member
Author
There was a problem hiding this comment.
Even with such loose policy, we have to wrap code block with "// scalastyle:off hadoopconfiguration" in some test cases for setting the hadoop conf.
|
Test build #93552 has finished for PR 21873 at commit
|
|
Test build #93592 has finished for PR 21873 at commit
|
Member
|
Thanks! Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In most cases, we should use
spark.sessionState.newHadoopConf()instead ofsparkContext.hadoopConfiguration, so that the hadoop configurations specified in Spark sessionconfiguration will come into effect.
Add a rule matching
spark.sparkContext.hadoopConfigurationorspark.sqlContext.sparkContext.hadoopConfigurationto prevent the usage.How was this patch tested?
Unit test