Skip to content

Conversation

@mccheah
Copy link
Contributor

@mccheah mccheah commented Jul 27, 2018

What changes were proposed in this pull request?

Don't set service account name for the pod created in client mode

How was this patch tested?

Test should continue running smoothly in Jenkins.

@mccheah
Copy link
Contributor Author

mccheah commented Jul 27, 2018

@skonto can you try this with spark-rbac.yaml?

@mccheah
Copy link
Contributor Author

mccheah commented Jul 27, 2018

ok to test

@SparkQA
Copy link

SparkQA commented Jul 27, 2018

@SparkQA
Copy link

SparkQA commented Jul 27, 2018

Test build #93694 has finished for PR 21900 at commit c22397c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 27, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1425/

@mccheah mccheah changed the title [SPARK-23146][K8S][TESTS] Don't set service account name for client mode test [SPARK-24963][K8S][TESTS] Don't set service account name for client mode test Jul 30, 2018
@asfgit asfgit closed this in d6b7545 Jul 30, 2018
@skonto
Copy link
Contributor

skonto commented Jul 30, 2018

@mccheah Thanks I will give it a shot. Sorry missed it. Will try with the internal ci job, should be ok.

@skonto
Copy link
Contributor

skonto commented Jul 30, 2018

@felixcheung @mccheah this was not fixed.
You need to add this line: withServiceAccount(kubernetesTestComponents.serviceAccountName)
in the driver's pod spec.
It still fails with:

User "system:serviceaccount:spark:default" cannot get pods in the namespace "spark".

With the above addition it runs fine.

robert3005 pushed a commit to palantir/spark that referenced this pull request Jul 31, 2018
…ode test

## What changes were proposed in this pull request?

Don't set service account name for the pod created in client mode

## How was this patch tested?

Test should continue running smoothly in Jenkins.

Author: mcheah <mcheah@palantir.com>

Closes apache#21900 from mccheah/fix-integration-test-service-account.
@robert3005 robert3005 deleted the fix-integration-test-service-account branch August 11, 2018 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants