[SPARK-24967][SQL] Avro: Use internal.Logging instead for logging #21914
Conversation
|
@HyukjinKwon, thanks! I am a bot who has found some folks who might be able to help with the review:@gatorsmile and @cloud-fan |
|
Test build #93774 has finished for PR 21914 at commit
|
| private[avro] class AvroFileFormat extends FileFormat with DataSourceRegister { | ||
| private val log = LoggerFactory.getLogger(getClass) | ||
| private[avro] class AvroFileFormat extends FileFormat | ||
| with DataSourceRegister with Logging with Serializable { |
There was a problem hiding this comment.
Did you make it Serializable specially? If so, what is the reason?
There was a problem hiding this comment.
Looks it has to be otherwise it throws an exception about serialization. Same thing is done in ParquetFileFormat too to allow to log everywhere.
|
LGTM, merging to master! |
## What changes were proposed in this pull request? Looks Avro uses direct `getLogger` to create a SLF4J logger. Should better use `internal.Logging` instead. ## How was this patch tested? Exiting tests. Author: hyukjinkwon <gurwls223@apache.org> Closes apache#21914 from HyukjinKwon/avro-log.
|
hii, @HyukjinKwon , friend. which jar should I add ? |
|
Please ask that to the mailing list. |
Looks Avro uses direct `getLogger` to create a SLF4J logger. Should better use `internal.Logging` instead. Exiting tests. Author: hyukjinkwon <gurwls223@apache.org> Closes apache#21914 from HyukjinKwon/avro-log. (cherry picked from commit fca0b85)
6 participants
What changes were proposed in this pull request?
Looks Avro uses direct
getLoggerto create a SLF4J logger. Should better useinternal.Logginginstead.How was this patch tested?
Exiting tests.