[SPARK-24972][SQL] PivotFirst could not handle pivot columns of complex types #21926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maryannxue, thanks! I am a bot who has found some folks who might be able to help with the review:@gatorsmile, @yhuai and @marmbrus |
maryannxue
commented
Jul 30, 2018
| // alternate plan that instead uses two steps of aggregation. | ||
| val namedAggExps: Seq[NamedExpression] = aggregates.map(a => Alias(a, a.sql)()) | ||
| val bigGroup = groupByExprs ++ pivotColumn.references | ||
| val namedPivotCol = pivotColumn match { |
Contributor
Author
There was a problem hiding this comment.
This is to revert the original walk-around aimed to avoid the PivotFirst issue. Now that we have PivotFirst working alright for complex types, we can revert it.
|
Test build #93815 has finished for PR 21926 at commit
|
Contributor
Author
|
retest this please |
|
Test build #93818 has finished for PR 21926 at commit
|
gatorsmile
reviewed
Jul 31, 2018
| case Pivot(groupByExprsOpt, pivotColumn, pivotValues, aggregates, child) => | ||
| if (!RowOrdering.isOrderable(pivotColumn.dataType)) { | ||
| throw new AnalysisException( | ||
| s"Invalid pivot column '${pivotColumn}'. Pivot columns must be comparable.") |
Member
There was a problem hiding this comment.
To the other reviewers: this is consistent with the requirements of group-by columns.
Member
|
LGTM Thanks! Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When the pivot column is of a complex type, the eval() result will be an UnsafeRow, while the keys of the HashMap for column value matching is a GenericInternalRow. As a result, there will be no match and the result will always be empty.
So for a pivot column of complex-types, we should:
PivotFirstcode path,PivotFirstshould use a TreeMap instead of HashMap for such columns.This PR has also reverted the walk-around in Analyzer that had been introduced to avoid this
PivotFirstissue.How was this patch tested?
Added UT.