-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-24979][SQL] add AnalysisHelper#resolveOperatorsUp #21932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cloud-fan, thanks! I am a bot who has found some folks who might be able to help with the review:@gatorsmile, @yhuai and @rxin |
|
Do we really need this? It's almost always the case for resolution that you'd want to do bottom up, so I thought Michael's original design to just call it resolveOperators make a lot of sense. |
|
@rxin there are different patterns
It's a little confusing to only have |
|
Test build #93833 has finished for PR 21932 at commit
|
|
It sounds reasonable to me. cc @rxin |
|
Test build #94348 has finished for PR 21932 at commit
|
|
retest this please |
|
Test build #94351 has finished for PR 21932 at commit
|
gatorsmile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! Merged to master.
What changes were proposed in this pull request?
This is a followup of #21822
Similar to
TreeNode,AnalysisHelpershould also provide 3 versions of transformations:resolveOperatorsUp,resolveOperatorsDownandresolveOperators.This PR adds the missing
resolveOperatorsUp, and also fixes some code style which is missed in #21822How was this patch tested?
existing tests.