Skip to content

[SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics #22279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LucaCanali wants to merge 3 commits into from
Closed

[SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics #22279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a990758
YARN applicationMaster metrics should not register static metrics
LucaCanali Aug 30, 2018
fd11730
Implemented extra flag to start as in the PR discussion.
LucaCanali Dec 12, 2018
9c21f16
formatting
LucaCanali Dec 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,13 @@ private[spark] class MetricsSystem private (

metricsConfig.initialize()

def start() {
def start(registerStaticSources: Boolean = true) {
require(!running, "Attempting to start a MetricsSystem that is already running")
running = true
StaticSources.allSources.foreach(registerSource)
registerSources()
if (registerStaticSources) {
StaticSources.allSources.foreach(registerSource)
registerSources()
}
registerSinks()
sinks.foreach(_.start)
}
Expand Down
3 changes: 2 additions & 1 deletion resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,8 @@ private[spark] class ApplicationMaster(args: ApplicationMasterArguments) extends
val ms = MetricsSystem.createMetricsSystem("applicationMaster", sparkConf, securityMgr)
val prefix = _sparkConf.get(YARN_METRICS_NAMESPACE).getOrElse(appId)
ms.registerSource(new ApplicationMasterSource(prefix, allocator))
ms.start()
// do not register static sources in this case as per SPARK-25277
ms.start(false)
metricsSystem = Some(ms)
reporterThread = launchReporterThread()
}
Expand Down