[SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to use main method #22491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #96351 has finished for PR 22491 at commit
|
# Conflicts: # sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/UnsafeArrayDataBenchmark.scala
|
Test build #96463 has finished for PR 22491 at commit
|
Member
Author
|
retest this please |
|
Test build #96467 has finished for PR 22491 at commit
|
Member
Author
|
retest this please |
|
Test build #96468 has finished for PR 22491 at commit
|
Member
Author
|
@dongjoon-hyun This refactor is ready to go. Thanks. |
Member
|
Thank you for pinging me, @wangyum . |
Member
|
Retest this please. |
|
Test build #96862 has finished for PR 22491 at commit
|
Member
|
Could you review and merge wangyum#14 ? |
|
Test build #96878 has finished for PR 22491 at commit
|
|
Test build #96883 has finished for PR 22491 at commit
|
Member
|
Merged to master. |
Member
|
Thank you, @wangyum ! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Refactor `UnsafeArrayDataBenchmark` to use main method. Generate benchmark result: ```sh SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.UnsafeArrayDataBenchmark" ``` ## How was this patch tested? manual tests Closes apache#22491 from wangyum/SPARK-25483. Lead-authored-by: Yuming Wang <yumwang@ebay.com> Co-authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor
UnsafeArrayDataBenchmarkto use main method.Generate benchmark result:
SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt "sql/test:runMain org.apache.spark.sql.execution.benchmark.UnsafeArrayDataBenchmark"How was this patch tested?
manual tests