[SPARK-25699][SQL] Partially push down conjunctive predicated in ORC #22684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
gengliangwang
changed the title
viirya
reviewed
Oct 10, 2018
| )).get.toString | ||
| } | ||
|
|
||
| // Safely remove unsupported `StringContains` predicate and push down `LessThan` |
Member
There was a problem hiding this comment.
There is another predicate pushed down. We shall mention it too?
|
Test build #97187 has finished for PR 22684 at commit
|
|
Test build #97199 has finished for PR 22684 at commit
|
dbtsai
reviewed
Oct 10, 2018
| val leftBuilderOption = createBuilder(dataTypeMap, left, | ||
| newBuilder, canPartialPushDownConjuncts) | ||
| val rightBuilderOption = | ||
| createBuilder(dataTypeMap, right, newBuilder, canPartialPushDownConjuncts) |
Member
There was a problem hiding this comment.
Nit, can you make the format the same as leftBuilderOption? Also, add another empty line before (leftBuilderOption, rightBuilderOption). Thanks.
dbtsai
reviewed
Oct 10, 2018
| _ <- buildSearchArgument(dataTypeMap, child, newBuilder) | ||
| negate <- buildSearchArgument(dataTypeMap, child, builder.startNot()) | ||
| _ <- createBuilder(dataTypeMap, child, newBuilder, canPartialPushDownConjuncts = false) | ||
| negate <- createBuilder(dataTypeMap, child, builder.startNot(), false) |
Member
There was a problem hiding this comment.
Nit, can you explicitly call canPartialPushDownConjuncts = false?
Member
Author
There was a problem hiding this comment.
Then it has to be two lines..I am OK with that too.
dbtsai
reviewed
Oct 10, 2018
| newBuilder, canPartialPushDownConjuncts) | ||
| val rightBuilderOption = | ||
| createBuilder(dataTypeMap, right, newBuilder, canPartialPushDownConjuncts) | ||
| (leftBuilderOption, rightBuilderOption) match { |
dbtsai
reviewed
Oct 10, 2018
| _ <- buildSearchArgument(dataTypeMap, child, newBuilder) | ||
| negate <- buildSearchArgument(dataTypeMap, child, builder.startNot()) | ||
| _ <- createBuilder(dataTypeMap, child, newBuilder, canPartialPushDownConjuncts = false) | ||
| negate <- createBuilder(dataTypeMap, child, builder.startNot(), false) |
Member
|
LGTM. Just some styling feedback. Thanks. |
Member
|
Merged into master. Thanks. |
|
Test build #97209 has finished for PR 22684 at commit
|
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Inspired by apache#22574 . We can partially push down top level conjunctive predicates to Orc. This PR improves Orc predicate push down in both SQL and Hive module. ## How was this patch tested? New unit test. Closes apache#22684 from gengliangwang/pushOrcFilters. Authored-by: Gengliang Wang <gengliang.wang@databricks.com> Signed-off-by: DB Tsai <d_tsai@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Inspired by #22574 .
We can partially push down top level conjunctive predicates to Orc.
This PR improves Orc predicate push down in both SQL and Hive module.
How was this patch tested?
New unit test.