Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Oct 10, 2018

What changes were proposed in this pull request?

Fix old oversight in API: Java flatMapValues needs a FlatMapFunction

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Oct 10, 2018

Test build #97217 has finished for PR 22690 at commit b1a88d5.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 10, 2018

Test build #97223 has finished for PR 22690 at commit 587aa89.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 10, 2018

Test build #97225 has finished for PR 22690 at commit 6c6c1a3.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 11, 2018

Test build #97226 has finished for PR 22690 at commit a35b54f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking API change?

@srowen
Copy link
Member Author

srowen commented Oct 11, 2018

Yes, for 3.0. it's an old API mistake

@SparkQA
Copy link

SparkQA commented Oct 12, 2018

Test build #97316 has finished for PR 22690 at commit 216bf7c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Oct 12, 2018

Merged to master

@asfgit asfgit closed this in 1ddfab8 Oct 12, 2018
@srowen srowen deleted the SPARK-19287 branch October 15, 2018 16:10
@HyukjinKwon
Copy link
Member

cc @cloud-fan and @gatorsmile

Should we update migration guide as well?

@srowen
Copy link
Member Author

srowen commented Oct 25, 2018

Yeah let me go back and add a note about several recent changes like this.

@srowen
Copy link
Member Author

srowen commented Oct 25, 2018

Actually sorry for the ignorant question @HyukjinKwon but is there a migration guide for things outside SQL and MLlib? those are the two I've found. This one isn't specific to those two. I tagged the JIRA as release-notes because this deserves a mention to be sure. By itself there's not much more to know about the migration than that a function return type changed.

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
…ction returning Iterable, not Iterator

## What changes were proposed in this pull request?

Fix old oversight in API: Java `flatMapValues` needs a `FlatMapFunction`

## How was this patch tested?

Existing tests.

Closes apache#22690 from srowen/SPARK-19287.

Authored-by: Sean Owen <sean.owen@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants