[SPARK-25712][Core][Minor] Improve usage message of start-master.sh and start-slave.sh #22700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
commented
Oct 11, 2018
| pattern+="\|Using Spark's default log4j profile:" | ||
| pattern+="\|Registered signal handlers for" | ||
| pattern+="\|Started daemon with process name" | ||
| pattern+="\|Registered signal handler for" |
Member
Author
There was a problem hiding this comment.
The output of SignalUtils is changed.
Member
There was a problem hiding this comment.
Ur, could you add these patterns to STS in this PR?
Member
Author
There was a problem hiding this comment.
Sorry, what is STS?
Member
There was a problem hiding this comment.
Oh, I mean Spark Thrift Server; sbin/start-thriftserver.sh.
Member
Author
There was a problem hiding this comment.
I tried but seems that STS has bigger problem other than such output: it didn't exist after parsing option -h. I suggest we can do it in another JIRA/PR.
gengliangwang
changed the title
srowen
approved these changes
Oct 11, 2018
dongjoon-hyun
approved these changes
Oct 11, 2018
|
Test build #97270 has finished for PR 22700 at commit
|
Member
|
Merged to master |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…nd start-slave.sh
## What changes were proposed in this pull request?
Currently if we run
```
./sbin/start-master.sh -h
```
We get
```
Usage: ./sbin/start-master.sh [options]
18/10/11 23:38:30 INFO Master: Started daemon with process name: 33907C02TL2JZGTF1
18/10/11 23:38:30 INFO SignalUtils: Registered signal handler for TERM
18/10/11 23:38:30 INFO SignalUtils: Registered signal handler for HUP
18/10/11 23:38:30 INFO SignalUtils: Registered signal handler for INT
Options:
-i HOST, --ip HOST Hostname to listen on (deprecated, please use --host or -h)
-h HOST, --host HOST Hostname to listen on
-p PORT, --port PORT Port to listen on (default: 7077)
--webui-port PORT Port for web UI (default: 8080)
--properties-file FILE Path to a custom Spark properties file.
Default is conf/spark-defaults.conf.
```
We can filter out some useless output.
## How was this patch tested?
Manual test
Closes apache#22700 from gengliangwang/improveStartScript.
Authored-by: Gengliang Wang <gengliang.wang@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently if we run
We get
We can filter out some useless output.
How was this patch tested?
Manual test