[SPARK-25714][SQL][followup] improve the comment inside BooleanSimplification rule #22711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
changed the title
cloud-fan
commented
Oct 13, 2018
| // See the chart: | ||
| // +---------+---------+---------+---------+ | ||
| // | p | q | p OR q | p AND q | | ||
| // | operand | operand | OR | AND | |
Contributor
Author
There was a problem hiding this comment.
AND and OR is commutative, so we can reduce the entries in this table
cloud-fan
commented
Oct 13, 2018
| // | UNKNOWN | UNKNOWN | UNKNOWN | UNKNOWN | | ||
| // +---------+---------+---------+---------+ | ||
|
|
||
| // This can break if a is null and c is false, so a can't be nullable. |
Contributor
Author
There was a problem hiding this comment.
explain which input can break it, so it's easier to understand.
Member
There was a problem hiding this comment.
The current code will not break. Thus, the comment is confusing to the future reader. To make it clear, we can just give the actual value.
(NULL And (NULL Or FALSE)) = NULL, but (NULL And FALSE) = FALSE. Thus, a can't be nullable.
cloud-fan
commented
Oct 13, 2018
| case (a Or b) And c if !a.nullable && a.semanticEquals(Not(c)) => And(b, c) | ||
| case (a Or b) And c if !b.nullable && b.semanticEquals(Not(c)) => And(a, c) | ||
| // This can break if c is null and b is false, so c can't be nullable. | ||
| case (a Or b) And c if !c.nullable && a.semanticEquals(Not(c)) => And(b, c) |
Contributor
Author
There was a problem hiding this comment.
b.nullable and c.nullable are same, because a.semanticEquals(Not(c)).
Contributor
Author
|
cc @gatorsmile |
|
Test build #97332 has finished for PR 22711 at commit
|
|
Test build #97334 has finished for PR 22711 at commit
|
Member
|
retest this please |
|
Test build #97342 has finished for PR 22711 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Oct 13, 2018
…fication rule ## What changes were proposed in this pull request? improve the code comment added in https://github.com/apache/spark/pull/22702/files ## How was this patch tested? N/A Closes #22711 from cloud-fan/minor. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: gatorsmile <gatorsmile@gmail.com> (cherry picked from commit b73f76b) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Member
|
LGTM Thanks! Merged to master/2.4 |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…fication rule ## What changes were proposed in this pull request? improve the code comment added in https://github.com/apache/spark/pull/22702/files ## How was this patch tested? N/A Closes apache#22711 from cloud-fan/minor. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
improve the code comment added in https://github.com/apache/spark/pull/22702/files
How was this patch tested?
N/A