[SPARK-25738][SQL] Fix LOAD DATA INPATH for hdfs port #22733
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LOAD DATA INPATH didn't work if the defaultFS included a port for hdfs. Handling this just requires a small change to use the correct URI constructor.
squito
commented
Oct 15, 2018
Contributor
Author
squito
left a comment
squito
left a comment
There was a problem hiding this comment.
I wasn't sure about the best place to put the test, I decided to put it next to the other tests on LOAD DATA INPATH in SQLQuerySuites, though its not running full sql queries. I thought a test just on makeQualified would be much easier to deal with than a full query. Is there a standard place to put tests on helper functions for files like tables.scala?
also if a reviewer would just rewrite themselves to organize tests in the right way, that is fine, this can be abandoned.
| } | ||
| try { | ||
| val newUri = new URI(scheme, authority, pathUri.getPath, pathUri.getFragment) | ||
| val newUri = new URI(scheme, authority, pathUri.getPath, null, pathUri.getFragment) |
Contributor
Author
There was a problem hiding this comment.
this change is all that's needed to fix the bug, the rest is for testing
Member
|
CC @sujith71955 |
Contributor
|
LGTM. |
Contributor
|
LGTM |
|
Test build #97413 has finished for PR 22733 at commit
|
Contributor
|
Merging to master / 2.4 |
asfgit
pushed a commit
that referenced
this pull request
Oct 16, 2018
## What changes were proposed in this pull request? LOAD DATA INPATH didn't work if the defaultFS included a port for hdfs. Handling this just requires a small change to use the correct URI constructor. ## How was this patch tested? Added a unit test, ran all tests via jenkins Closes #22733 from squito/SPARK-25738. Authored-by: Imran Rashid <irashid@cloudera.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit fdaa998) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? LOAD DATA INPATH didn't work if the defaultFS included a port for hdfs. Handling this just requires a small change to use the correct URI constructor. ## How was this patch tested? Added a unit test, ran all tests via jenkins Closes apache#22733 from squito/SPARK-25738. Authored-by: Imran Rashid <irashid@cloudera.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
LOAD DATA INPATH didn't work if the defaultFS included a port for hdfs.
Handling this just requires a small change to use the correct URI
constructor.
How was this patch tested?
Added a unit test, ran all tests via jenkins