-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-25838][ML] Remove formatVersion from Saveable #22830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #98039 has finished for PR 22830 at commit
|
|
Test build #98082 has finished for PR 22830 at commit
|
|
Test build #98088 has finished for PR 22830 at commit
|
|
cc @mengxr any idea why we have this |
|
Retest this please. |
| } | ||
|
|
||
| override protected def formatVersion: String = "1.0" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean by visible to users? It is protected, it is visible only if a user extends the class...
|
Who introduced this? We should ask the person that introduced it whether it can be removed. |
|
Test build #98179 has finished for PR 22830 at commit
|
|
this was introduced by @jkbradley in 975bcef. |
|
retest this please |
|
Perhaps @jkbradley and @mengxr can comment on it. If the trait is inheritable, then protected still means it is part of the API contract. |
|
Test build #98194 has finished for PR 22830 at commit
|
|
retest this please |
|
Test build #98220 has finished for PR 22830 at commit
|
|
Just saw this after reviewing a lot of old PRs. Yes this can be removed. It's old and not used, and think it was superseded by the "SaveLoadVx_0" class pattern. I think it can be removed in Spark 3 as it's not user visible. |
|
Test build #103166 has finished for PR 22830 at commit
|
|
Merged to master |
What changes were proposed in this pull request?
Saveableinterface introducesformatVersionwhich is protected and it is used nowhere. So the PR proposes to remove it.How was this patch tested?
existing tests