[SPARK-25862][SQL] Remove rangeBetween APIs introduced in SPARK-21608 #22870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #98173 has finished for PR 22870 at commit
|
gatorsmile
reviewed
Oct 29, 2018
| (lower, upper) match { | ||
| case (l: Expression, u: Expression) if !isValidFrameBoundary(l, u) => | ||
| TypeCheckFailure(s"Window frame upper bound '$upper' does not followes the lower bound " + | ||
| TypeCheckFailure(s"Window frame upper bound '$upper' does not follow the lower bound " + |
Member
There was a problem hiding this comment.
We need to generate the result file for org.apache.spark.sql.SQLQueryTestSuite
Fix tests at PR 22870
|
Test build #98180 has finished for PR 22870 at commit
|
Member
|
retest this please |
|
Test build #98184 has finished for PR 22870 at commit
|
Member
|
retest this please. |
|
Test build #98191 has finished for PR 22870 at commit
|
Member
|
LGTM Thanks! Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This patch removes the rangeBetween functions introduced in SPARK-21608. As explained in SPARK-25841, these functions are confusing and don't quite work. We will redesign them and introduce better ones in SPARK-25843. ## How was this patch tested? Removed relevant test cases as well. These test cases will need to be added back in SPARK-25843. Closes apache#22870 from rxin/SPARK-25862. Lead-authored-by: Reynold Xin <rxin@databricks.com> Co-authored-by: hyukjinkwon <gurwls223@apache.org> Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch removes the rangeBetween functions introduced in SPARK-21608. As explained in SPARK-25841, these functions are confusing and don't quite work. We will redesign them and introduce better ones in SPARK-25843.
How was this patch tested?
Removed relevant test cases as well. These test cases will need to be added back in SPARK-25843.