[SPARK-25867][ML] Remove KMeans computeCost

[mgaido91]

What changes were proposed in this pull request?

The PR removes the deprecated method computeCost of KMeans.

How was this patch tested?

NA

[SparkQA]

Test build #98201 has finished for PR 22875 at commit 9ee93b1.

• This patch fails build dependency tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mgaido91]

retest this please

[SparkQA]

Test build #98210 has finished for PR 22875 at commit 9ee93b1.

• This patch fails MiMa tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #98212 has finished for PR 22875 at commit 62f8606.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mgaido91]

cc @holdenk @srowen

[SparkQA]

Test build #98680 has finished for PR 22875 at commit c2fdddc.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #98874 has finished for PR 22875 at commit 6e2d501.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mgaido91]

any commetn on this @srowen @holdenk ?

[SparkQA]

Test build #99048 has finished for PR 22875 at commit f09e985.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mgaido91]

retest this please

[srowen]

Just grepping for computeCost -- do any examples need updating? I see some instances but they may be a different computeCost.

But what about BisectingKMeans too?

[mgaido91]

Yes, the problem is that there is also the computeCost of BisectingKMeans. I proposed to deprecate it in 2.4 and remove in 3.0, but I didn't manage to have it done for 2.4 (please refer to the discussions on #22764 and #22756 for the details). So computeCost of BisectingKMeans cannot be removed in 3.0 (unfortunately). The examples for KMeans have already been updated using ClusteringEvaluator in #19676.

[srowen]

How about BisecingKMeansModel? That's what I was looking at. That computeCost is also deprecated.

[mgaido91]

Yes, it was deprecated in #22756 and it is deprecated since 3.0, so we cannot remove it...

[srowen]

Ah OK I wasn't reading that carefully.

[SparkQA]

Test build #99057 has finished for PR 22875 at commit f09e985.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Apologies for the merge conflict now, but looks OK otherwise.

[mgaido91]

thanks for your review @srowen

[SparkQA]

Test build #99109 has finished for PR 22875 at commit 2b18e55.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mgaido91]

retest this please

[SparkQA]

Test build #99123 has finished for PR 22875 at commit 2b18e55.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[mgaido91]

retest this please

[SparkQA]

Test build #99133 has finished for PR 22875 at commit 2b18e55.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

OK by me; apologies for another rebase though. We're merging lots of changes that need MiMa exclusions and it keeps conflicting.

[mgaido91]

sure, thanks @srowen , no need to apologize at all, thanks for your help reviewing this.

[SparkQA]

Test build #99174 has finished for PR 22875 at commit 692ff63.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• class RuleSummary(
• class QueryPlanningTracker
• class QueryExecution(

[srowen]

Merged to master