-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3418] Sparse Matrix support (CCS) and additional native BLAS operations added #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d2d5851
[SPARK-3418][MLlib] Sparse Matrix support and additional native BLAS …
brkyvz dc7be71
[SPARK-3418][MLlib] Matrix unit tests expanded with indexing and upda…
brkyvz 6025297
[SPARK-3418] Fixed Scala-style errors
brkyvz 204a3f7
[SPARK-3418] Fixed failing Matrix unit test
brkyvz d16e8a0
[SPARK-3418] Fixed style issues and added documentation for methods
brkyvz 2508577
[SPARK-3418] Fixed one more style issue
brkyvz f35a161
[SPARK-3418] Code review comments addressed and multiplication furthe…
brkyvz 421045f
[SPARK-3418] New code review comments addressed
brkyvz d3a8a16
[SPARK-3418] Squashed missing alpha bug.
brkyvz 7af2f83
sealed traits Vector and Matrix
brkyvz 4b7dbec
9/17 comments addressed
brkyvz f0bae57
[SPARK-3418] Fixed MiMa compatibility issues (excluded from check)
brkyvz 47e49d5
really fixed MiMa issue
brkyvz 88814ed
Hopefully fixed MiMa this time
brkyvz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is worth testing whether we should use
f2jBLASornativeBLASfor level-2.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nativeBLAS was faster across the board. Here are the results (in ms):