Skip to content

Conversation

@ScrapCodes
Copy link
Member

...erators.

@SparkQA
Copy link

SparkQA commented Sep 11, 2014

QA tests have started for PR 2358 at commit 12a20f2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 11, 2014

QA tests have finished for PR 2358 at commit 12a20f2.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class NonASCIICharacterChecker extends ScalariformChecker

@ScrapCodes ScrapCodes changed the title [SPARK-2182] Scalastyle rule blocking (non keyboard typeable) unicode op... [SPARK-2182] Scalastyle rule blocking non ascii characters. Sep 12, 2014
@pwendell
Copy link
Contributor

Can you submit a patch with a unicode character to show this is working? Other than that LGTM

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have started for PR 2358 at commit 3dbf037.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have finished for PR 2358 at commit 3dbf037.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class NonASCIICharacterChecker extends ScalariformChecker

@ScrapCodes
Copy link
Member Author

Hey @pwendell, I can remove the commit once you confirm it works.

@ash211
Copy link
Contributor

ash211 commented Sep 15, 2014

A flagged character looks like this:

Running Scala style checks
=========================================================================
Scalastyle checks failed at following occurrences:
error file=/home/jenkins/workspace/SparkPullRequestBuilder/core/src/main/scala/org/apache/spark/SparkContext.scala message=non.ascii.character.disallowed.message line=304 column=22
java.lang.RuntimeException: exists error
    at scala.sys.package$.error(package.scala:27)
    at scala.Predef$.error(Predef.scala:142)
[error] (core/*:scalastyle) exists error

Seems reasonable to merge with that confirmation

@ScrapCodes
Copy link
Member Author

Yeah Thanks, @ash211 I will get rid of that commit.

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have started for PR 2358 at commit 12a20f2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have finished for PR 2358 at commit 12a20f2.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class NonASCIICharacterChecker extends ScalariformChecker

@pwendell
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have started for PR 2358 at commit 12a20f2.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Sep 16, 2014

QA tests have started for PR 2358 at commit 12a20f2.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 16, 2014

QA tests have finished for PR 2358 at commit 12a20f2.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ArrayConstructor extends net.razorvine.pickle.objects.ArrayConstructor
    • class NonASCIICharacterChecker extends ScalariformChecker
    • class SCCallSiteSync(object):

@asfgit asfgit closed this in 7b8008f Sep 16, 2014
@ScrapCodes ScrapCodes deleted the scalastyle-unicode branch June 3, 2015 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants