[SPARK-26652][SQL] Remove fromJSON and fromString from Literal #23603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #101478 has finished for PR 23603 at commit
|
|
Test build #101479 has finished for PR 23603 at commit
|
Member
|
retest this please |
HyukjinKwon
approved these changes
Jan 21, 2019
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Yea, I agree with this change. Looks good if the tests pass.
cloud-fan
approved these changes
Jan 21, 2019
|
Test build #101483 has finished for PR 23603 at commit
|
Member
|
Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? The `fromString` and `fromJSON` methods of the `Literal` object are removed because they are not used. Closes apache#23596 Closes apache#23603 from MaxGekk/remove-literal-fromstring. Authored-by: Maxim Gekk <maxim.gekk@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
fromStringandfromJSONmethods of theLiteralobject are removed because they are not used.Closes #23596