Skip to content

[SPARK-19591][ML][MLlib][FOLLOWUP] Add sample weights to decision trees - fix tolerance #23682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imatiach-msft wants to merge 2 commits into from
+4 −1
Closed

[SPARK-19591][ML][MLlib][FOLLOWUP] Add sample weights to decision trees - fix tolerance #23682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94335ae
[SPARK-19591][ML][MLlib][FOLLOWUP] Add sample weights to decision tre…
imatiach-msft Jan 29, 2019
b34d88e
updated based on comments
imatiach-msft Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion mllib/src/main/scala/org/apache/spark/ml/tree/impl/RandomForest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,8 +1050,11 @@ private[spark] object RandomForest extends Logging with Serializable {
// Calculate the expected number of samples for finding splits
val weightedNumSamples = samplesFractionForFindSplits(metadata) *
metadata.weightedNumExamples
// scale tolerance by number of samples with constant factor
// Note: constant factor was tuned by running some tests where there were no zero
// feature values and validating we are never within tolerance
val tolerance = Utils.EPSILON * unweightedNumSamples * 100
// add expected zero value count and get complete statistics
val tolerance = Utils.EPSILON * unweightedNumSamples * unweightedNumSamples
val valueCountMap = if (weightedNumSamples - partNumSamples > tolerance) {
partValueCountMap + (0.0 -> (weightedNumSamples - partNumSamples))
} else {
Expand Down