Skip to content

[SPARK-3531][SQL]select null from table would throw a MatchError #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrian-wang wants to merge 1 commit into from
Closed

[SPARK-3531][SQL]select null from table would throw a MatchError #2396

adrian-wang wants to merge 1 commit into from

Conversation

@adrian-wang
Copy link
Contributor

@adrian-wang adrian-wang commented Sep 15, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have started for PR 2396 at commit 0981c42.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 15, 2014

QA tests have finished for PR 2396 at commit 0981c42.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@adrian-wang
Copy link
Contributor Author

adrian-wang commented Sep 15, 2014

This is according to how Hive handle immediate null value in queries.

marmbrus
marmbrus reviewed Sep 16, 2014
View reviewed changes
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala Outdated
Copy link
Contributor

@marmbrus marmbrus Sep 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be better to create a query test, since then it actually checks to make sure hive is returning the same answer.

@adrian-wang
Copy link
Contributor Author

adrian-wang commented Sep 17, 2014

Thanks, Michael, I've moved the test as a query test.

@SparkQA
Copy link

SparkQA commented Sep 17, 2014

QA tests have started for PR 2396 at commit ac4fb5d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 17, 2014

QA tests have finished for PR 2396 at commit ac4fb5d.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have started for PR 2396 at commit 2458229.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20738/

@adrian-wang
Copy link
Contributor Author

adrian-wang commented Sep 24, 2014

retest this please.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have started for PR 2396 at commit 2458229.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have finished for PR 2396 at commit 2458229.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20739/

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have finished for PR 2396 at commit 2458229.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20740/

@marmbrus
Copy link
Contributor

marmbrus commented Sep 26, 2014

Thanks :) Merged to master.

@asfgit asfgit closed this in 0ec2d2e Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrian-wang @SparkQA @marmbrus