[SPARK-27064][SS] create StreamingWrite at the beginning of streaming execution #23981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Mar 5, 2019
| @@ -585,7 +585,7 @@ abstract class StreamExecution( | |||
| options: Map[String, String], | |||
| inputPlan: LogicalPlan): StreamingWrite = { | |||
| val writeBuilder = table.newWriteBuilder(new DataSourceOptions(options.asJava)) | |||
| .withQueryId(runId.toString) | |||
| .withQueryId(id.toString) | |||
There was a problem hiding this comment.
this is an unrelated change, but it was obviously a mistake: the sink doesn't care about the runId which gets changed after query restart. The sink needs the id which is reliable across the life cycle of the stream query.
No builtin streaming sinks use this id, so this is for future-proof.
|
Test build #103059 has finished for PR 23981 at commit
|
|
Test build #103078 has finished for PR 23981 at commit
|
|
retest this please |
|
Test build #103092 has finished for PR 23981 at commit
|
|
LGTM. |
|
retest this please |
|
Test build #103412 has finished for PR 23981 at commit
|
|
retest this please |
|
Test build #103426 has finished for PR 23981 at commit
|
|
thanks, merging to master! |
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
May 15, 2019
… execution ## What changes were proposed in this pull request? According to the [design](https://docs.google.com/document/d/1vI26UEuDpVuOjWw4WPoH2T6y8WAekwtI7qoowhOFnI4/edit?usp=sharing), the life cycle of `StreamingWrite` should be the same as the read side `MicroBatch/ContinuousStream`, i.e. each run of the stream query, instead of each epoch. This PR fixes it. ## How was this patch tested? existing tests Closes apache#23981 from cloud-fan/dsv2. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
According to the design, the life cycle of
StreamingWriteshould be the same as the read sideMicroBatch/ContinuousStream, i.e. each run of the stream query, instead of each epoch.This PR fixes it.
How was this patch tested?
existing tests