[SPARK-27117][SQL] current_date/current_timestamp should not refer to columns with ansi parser mode #24039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
maropu
reviewed
Mar 9, 2019
| UnresolvedAttribute.quoted(ctx.name.getText) | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
We need to change the current behaviour of select current_date/select current_timestamp in the non-ansi mode? If so, we need to update the migration guide:
// the current behaivour in the non-ansi mode
scala> sql("SET spark.sql.parser.ansi.enabled=false")
scala> sql("SELECT CURRENT_TIMESTAMP").show
+--------------------+
| current_timestamp()|
+--------------------+
|2019-02-25 16:26:...|
+--------------------+
Contributor
Author
There was a problem hiding this comment.
I don't think so, this behavior change only makes sense in ansi mode.
viirya
reviewed
Mar 9, 2019
| } | ||
| } | ||
|
|
||
| override def visitCurrentDatetime(ctx: CurrentDatetimeContext): AnyRef = { |
Member
There was a problem hiding this comment.
Shouldn't it be?
override def visitCurrentDatetime(ctx: CurrentDatetimeContext): Expression = withOrigin(ctx) {
...
}
|
Test build #103262 has finished for PR 24039 at commit
|
maropu
reviewed
Mar 11, 2019
| } | ||
| } | ||
|
|
||
| override def visitCurrentDatetime(ctx: CurrentDatetimeContext): AnyRef = withOrigin(ctx) { |
|
Test build #103297 has finished for PR 24039 at commit
|
Member
|
retest this please |
maropu
approved these changes
Mar 11, 2019
|
Test build #103303 has finished for PR 24039 at commit
|
viirya
approved these changes
Mar 11, 2019
|
Test build #103307 has finished for PR 24039 at commit
|
Contributor
Author
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #19559 .
It revisits https://issues.apache.org/jira/browse/SPARK-27117 , which should be an invalid use case according to the SQL standard.
current_date/current_timestampare reserved keywords, if users want to access columns namedcurrent_date/current_timestamp, they should quote the name likeselect `current_date` from tblIf ansi mode is not enabled(which is the default), this PR won't introduce any changes.
How was this patch tested?
a new test case