[SPARK-3589][Minor]remove redundant code #2445
Conversation
|
QA tests have started for PR 2445 at commit
|
|
QA tests have finished for PR 2445 at commit
|
There was a problem hiding this comment.
this one is read downstream by SparkSubmitDriverBootstrapper - it is not redundant.
There was a problem hiding this comment.
@pwendell I mean we just export CLASSPATH before entering if conditional(line 161). Are the two different?
There was a problem hiding this comment.
Oh I see, we already exported it out there. I put this here to make it more explicit that these are the variables needed by SparkSubmitDriverBootstrapper, so even though this line is somewhat redundant, it's here for code readability reasons.
There was a problem hiding this comment.
ok, it does make sense.
|
Thanks - I merged this but I removed one of the changes which was incorrect. |
https://issues.apache.org/jira/browse/SPARK-3589 "export CLASSPATH" in spark-class is redundant since same variable is exported before. We could reuse defined value "isYarnCluster" in SparkSubmit.scala. Author: WangTaoTheTonic <barneystinson@aliyun.com> Closes #2445 from WangTaoTheTonic/removeRedundant and squashes the following commits: 6fb6872 [WangTaoTheTonic] remove redundant code (cherry picked from commit 471e6a3) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
https://issues.apache.org/jira/browse/SPARK-3589 "export CLASSPATH" in spark-class is redundant since same variable is exported before. We could reuse defined value "isYarnCluster" in SparkSubmit.scala. Author: WangTaoTheTonic <barneystinson@aliyun.com> Closes apache#2445 from WangTaoTheTonic/removeRedundant and squashes the following commits: 6fb6872 [WangTaoTheTonic] remove redundant code (cherry picked from commit 471e6a3) Signed-off-by: Patrick Wendell <pwendell@gmail.com>
4 participants
https://issues.apache.org/jira/browse/SPARK-3589
"export CLASSPATH" in spark-class is redundant since same variable is exported before.
We could reuse defined value "isYarnCluster" in SparkSubmit.scala.