Skip to content

Conversation

@gvramana
Copy link
Contributor

Supported modulus operation using % operator on fractional datatypes FloatType, DoubleType and DecimalType
Example:
SELECT 1388632775.0 % 60 from tablename LIMIT 1

Author : Venkata Ramana Gollamudi ramana.gollamudi@huawei.com

@SparkQA
Copy link

SparkQA commented Sep 19, 2014

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

ok to test

@marmbrus
Copy link
Contributor

Thanks for working on this! Could you also add some tests to HiveQuerySuite?

@SparkQA
Copy link

SparkQA commented Sep 20, 2014

QA tests have started for PR 2457 at commit 193fa81.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 20, 2014

QA tests have finished for PR 2457 at commit 193fa81.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gvramana
Copy link
Contributor Author

Added testcase in HiveQuerySuite. Please verify and test. Thanks.

@SparkQA
Copy link

SparkQA commented Sep 23, 2014

QA tests have started for PR 2457 at commit c09bd5b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 23, 2014

QA tests have finished for PR 2457 at commit c09bd5b.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 23, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20698/

@gvramana
Copy link
Contributor Author

Fixed test failure by adding hive cache file, please re-test. Thanks

@SparkQA
Copy link

SparkQA commented Sep 23, 2014

QA tests have started for PR 2457 at commit 79172a8.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 23, 2014

QA tests have finished for PR 2457 at commit 79172a8.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 23, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20708/

@asfgit asfgit closed this in 1c62f97 Sep 23, 2014
@marmbrus
Copy link
Contributor

Thanks! I merged this to master.

@gvramana gvramana deleted the double_modulus_support branch September 29, 2014 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants