[SPARK-27816][SQL] make TreeNode tag type safe #24687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
viirya
approved these changes
May 23, 2019
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
Looks good. We can make sure we're getting/setting tagged object in correct type.
|
Test build #105717 has finished for PR 24687 at commit
|
gatorsmile
reviewed
May 23, 2019
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
LGTM
Thanks! Merged to master.
j-baker
pushed a commit
to palantir/spark
that referenced
this pull request
Jan 25, 2020
Add type parameter to `TreeNodeTag`. existing tests Closes apache#24687 from cloud-fan/tag. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: gatorsmile <gatorsmile@gmail.com>
cloud-fan
added a commit
to cloud-fan/spark
that referenced
this pull request
Jan 31, 2020
## What changes were proposed in this pull request? Add type parameter to `TreeNodeTag`. ## How was this patch tested? existing tests Closes apache#24687 from cloud-fan/tag. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add type parameter to
TreeNodeTag.How was this patch tested?
existing tests