-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28285][SQL][PYTHON][TESTS] Convert and port 'outer-join.sql' into UDF test base #25103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #107493 has finished for PR 25103 at commit
|
|
Test build #107801 has finished for PR 25103 at commit
|
|
retest this please |
|
Looks good to me in general if the tests pass |
|
Test build #107816 has finished for PR 25103 at commit
|
|
retest this please |
|
Test build #107861 has finished for PR 25103 at commit
|
|
@huaxingao, can you update the diff comparing to the original file? Looks a bit weird. |
|
diff updated. @HyukjinKwon |
|
Merged to master. |
|
Thanks a lot for your help! @HyukjinKwon |
What changes were proposed in this pull request?
This PR adds some tests converted from
outer-join.sqlto test UDFs. Please see contribution guide of this umbrella ticket - SPARK-27921.Diff comparing to 'outer-join.sql'
How was this patch tested?
Tested as guided in SPARK-27921.