Skip to content

[Build] Diff from branch point #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nchammas wants to merge 2 commits into from
Closed

[Build] Diff from branch point #2512

nchammas wants to merge 2 commits into from

Conversation

@nchammas
Copy link
Contributor

@nchammas nchammas commented Sep 23, 2014

Sometimes Jenkins posts spurious reports of new classes being added. I believe this stems from diffing the patch against master, as opposed to against master..., which starts from the commit the PR was branched from.

This patch fixes that behavior.

@nchammas nchammas changed the title diff from branch point [Build] Diff from branch point Sep 23, 2014
@nchammas
Copy link
Contributor Author

nchammas commented Sep 23, 2014

cc @pwendell @rxin

@SparkQA
Copy link

SparkQA commented Sep 23, 2014

QA tests have started for PR 2512 at commit a453c67.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 23, 2014

QA tests have finished for PR 2512 at commit a453c67.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 23, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20726/

ash211
ash211 reviewed Sep 24, 2014
View reviewed changes
dev/run-tests-jenkins Outdated
Copy link
Contributor

@ash211 ash211 Sep 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: piont -> point

Copy link
Contributor Author

@nchammas nchammas Sep 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thank you.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have started for PR 2512 at commit c065599.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

QA tests have finished for PR 2512 at commit c065599.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 24, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20736/

@pwendell
Copy link
Contributor

pwendell commented Sep 24, 2014

Looks good - thanks Nick.

@asfgit asfgit closed this in c429126 Sep 24, 2014
@nchammas nchammas deleted the diff-only-commits-ahead branch September 25, 2014 00:30
@nchammas
Copy link
Contributor Author

nchammas commented Sep 25, 2014

@pwendell Should this also be merged into branch-1.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nchammas @SparkQA @pwendell @ash211