Skip to content

Conversation

@jiangxb1987
Copy link
Contributor

What changes were proposed in this pull request?

The optimize rule PushDownPredicate has been combined into PushDownPredicates, update the comment that references the old rule.

How was this patch tested?

N/A

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Jul 20, 2019

Test build #107926 has finished for PR 25207 at commit 2c67b84.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Shall we make this as a follow-up of 74f1176 ?

@dongjoon-hyun
Copy link
Member

Please see #24956 (comment) , too.

@jiangxb1987 jiangxb1987 changed the title [MINOR][DOC] Update comment that references PushDownPredicate [SPARK-27815][SQL][FOLLOWUP][DOC] Update comment that references PushDownPredicate Jul 20, 2019
@jiangxb1987
Copy link
Contributor Author

@dongjoon-hyun updated!

@HyukjinKwon
Copy link
Member

Wait, are you use if it's related to do not leak SaveMode to file source v2 SPARK-27815?

@HyukjinKwon
Copy link
Member

Oh, ah. got it. Okay, let me switch the JIRA and merge.

@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member

Thank you so much, @jiangxb1987 and @HyukjinKwon !

yiheng pushed a commit to yiheng/spark that referenced this pull request Jul 24, 2019
…hDownPredicate`

## What changes were proposed in this pull request?

The optimize rule `PushDownPredicate` has been combined into `PushDownPredicates`, update the comment that references the old rule.

## How was this patch tested?

N/A

Closes apache#25207 from jiangxb1987/comment.

Authored-by: Xingbo Jiang <xingbo.jiang@databricks.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants