[SPARK-28455][core] Avoid overflow when calculating executor timeout time #25208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time. This would cause the timeout time to be negative, so executors would be timed out immediately (instead of never). I also tweaked a couple of log messages that could get pretty long when lots of executors were active. Added unit test (which failed without the fix).
|
Test build #107929 has finished for PR 25208 at commit
|
| activatedExecs += id | ||
| } else if (activatedExecs.size == 10) { | ||
| activatedExecs += "..." | ||
| } |
Member
There was a problem hiding this comment.
Shall we wrap this with if (log.isDebugEnabled) { ... }, too?
mgaido91
reviewed
Jul 20, 2019
| needTimeoutUpdate = true | ||
| activatedExecs += id | ||
| // Don't collect too many ids or the debug message becomes not very useful. | ||
| if (activatedExecs.size < 10) { |
Contributor
There was a problem hiding this comment.
what about having a method for this in order to avoid code duplication?
srowen
approved these changes
Jul 21, 2019
Contributor
|
LGTM |
|
Test build #108020 has finished for PR 25208 at commit
|
dongjoon-hyun
approved these changes
Jul 22, 2019
dongjoon-hyun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would cause the timeout time to be negative, so executors would be
timed out immediately (instead of never).
I also tweaked a couple of log messages that could get pretty long when
lots of executors were active.
Added unit test (which failed without the fix).