[SPARK-28189][SQL][FOLLOW-UP] Remove the unnecessary test in DataFrameSuite #25216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #107952 has finished for PR 25216 at commit
|
dongjoon-hyun
approved these changes
Jul 21, 2019
Member
There was a problem hiding this comment.
This PR removes a test coverage and all UTs passed. The Jenkins job fails at R packaging stage due to Jenkins restart. It's irrelevant to this PR.
+1, LGTM. Merged to master. Thank you for this followup, @maropu .
This is removed back according to @gatorsmile 's advice, @Tonix517 .
yiheng
pushed a commit
to yiheng/spark
that referenced
this pull request
Jul 24, 2019
…eSuite ## What changes were proposed in this pull request? This pr is to remove the unnecessary test in DataFrameSuite. ## How was this patch tested? N/A Closes apache#25216 from maropu/SPARK-28189-FOLLOWUP. Authored-by: Takeshi Yamamuro <yamamuro@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr is to remove the unnecessary test in DataFrameSuite.
How was this patch tested?
N/A