-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28469][SQL] Change CalendarIntervalType's readable string representation from calendarinterval to interval #25225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the title. Changing name is more important than adding simpleString.
|
Test build #107989 has finished for PR 25225 at commit
|
|
retest this please |
|
Thank you for updating. |
|
cc @gatorsmile |
|
Test build #107994 has finished for PR 25225 at commit
|
|
I'm +1 for this changes. |
|
Although PostgreSQL has several variants. In Spark side, we have no such things. So, this will not be misleading. How do you think about this PR, @gatorsmile ? |
|
+1, too. fyi: the cited from https://www.postgresql.org/docs/9.2/datatype.html |
|
Yep. I think it's okay by itself. Thank you for the pointer. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged to master. Thank you, @wangyum and @maropu .
cc @gatorsmile and @cloud-fan
|
+1 too |
What changes were proposed in this pull request?
This PR change
CalendarIntervalType's readable string representation fromcalendarintervaltointerval.How was this patch tested?
Existing UT