-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-25382][SQL][PYSPARK] Remove ImageSchema.readImages in 3.0 #25245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #108099 has finished for PR 25245 at commit
|
srowen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll tag the JIRA with release-notes and add a description of the breaking change. Looks OK in principle.
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala
Outdated
Show resolved
Hide resolved
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala
Outdated
Show resolved
Hide resolved
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala
Outdated
Show resolved
Hide resolved
|
Test build #108103 has finished for PR 25245 at commit
|
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala
Outdated
Show resolved
Hide resolved
WeichenXu123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment.
|
Test build #108104 has finished for PR 25245 at commit
|
|
Test build #108117 has finished for PR 25245 at commit
|
mllib/src/main/scala/org/apache/spark/ml/source/image/ImageFileFormat.scala
Outdated
Show resolved
Hide resolved
WeichenXu123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment.
|
Test build #108144 has finished for PR 25245 at commit
|
|
WDYT @WeichenXu123 ? I'm OK with removing less in this change if there's any question about what to keep. |
|
I am ok with @HyukjinKwon 's opinion. Will update PR then. |
|
Thanks @srowen and @WeichenXu123 |
|
Test build #108384 has finished for PR 25245 at commit
|
cebc9d0 to
02b4853
Compare
|
Test build #108389 has finished for PR 25245 at commit
|
|
Test build #108388 has finished for PR 25245 at commit
|
|
Test build #108434 has finished for PR 25245 at commit
|
|
Merged to master. |
What changes were proposed in this pull request?
This PR proposes to remove the deprecate
ImageSchema.readImages.How was this patch tested?
UT.