Skip to content

Conversation

@WeichenXu123
Copy link
Contributor

@WeichenXu123 WeichenXu123 commented Jul 24, 2019

What changes were proposed in this pull request?

This PR proposes to remove the deprecate ImageSchema.readImages.

How was this patch tested?

UT.

@SparkQA
Copy link

SparkQA commented Jul 24, 2019

Test build #108099 has finished for PR 25245 at commit b21aa23.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • raise RuntimeError(\"Creating instance of _ImageUtils class is disallowed.\")

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tag the JIRA with release-notes and add a description of the breaking change. Looks OK in principle.

@SparkQA
Copy link

SparkQA commented Jul 24, 2019

Test build #108103 has finished for PR 25245 at commit 450b9d8.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor Author

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment.

@SparkQA
Copy link

SparkQA commented Jul 24, 2019

Test build #108104 has finished for PR 25245 at commit 086e0ae.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 24, 2019

Test build #108117 has finished for PR 25245 at commit bcb4490.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor Author

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment.

@SparkQA
Copy link

SparkQA commented Jul 25, 2019

Test build #108144 has finished for PR 25245 at commit 6bbb35b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 29, 2019

WDYT @WeichenXu123 ? I'm OK with removing less in this change if there's any question about what to keep.

@WeichenXu123
Copy link
Contributor Author

I am ok with @HyukjinKwon 's opinion. Will update PR then.

@HyukjinKwon
Copy link
Member

Thanks @srowen and @WeichenXu123

@SparkQA
Copy link

SparkQA commented Jul 30, 2019

Test build #108384 has finished for PR 25245 at commit 8fb3f87.

  • This patch fails MiMa tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class _ImageSchema(object):
  • raise RuntimeError(\"Creating instance of _ImageSchema class is disallowed.\")

@WeichenXu123 WeichenXu123 force-pushed the remove_image_schema branch from cebc9d0 to 02b4853 Compare July 30, 2019 12:35
@SparkQA
Copy link

SparkQA commented Jul 30, 2019

Test build #108389 has finished for PR 25245 at commit 02b4853.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 30, 2019

Test build #108388 has finished for PR 25245 at commit cebc9d0.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 31, 2019

Test build #108434 has finished for PR 25245 at commit 6460c7a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@WeichenXu123 WeichenXu123 deleted the remove_image_schema branch August 3, 2019 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants