[SPARK-28564][CORE] Access history application defaults to the last attempt id #25301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
Member
|
ok to test |
| } | ||
| } | ||
|
|
||
| test("SPARK-28564: Access history application defaults to the last attempt id") { |
Member
There was a problem hiding this comment.
Hi, @cxzl25 .
Since you created a JIRA issue with Improvement type, we don't use JIRA ID in the test case name.
That's because we don't add JIRA ID prefix for all new features.
Contributor
Author
There was a problem hiding this comment.
ok, I remember now. thanks for your reminder
|
Test build #108412 has finished for PR 25301 at commit
|
vanzin
reviewed
Jul 30, 2019
Contributor
vanzin
left a comment
vanzin
left a comment
There was a problem hiding this comment.
Some suggestions otherwise looks ok.
| assert(code === 302, s"Unexpected status code $code for $url") | ||
| attemptId match { | ||
| case None => | ||
| assert(location.stripSuffix("/") === lastAttemptUrl.toString, s"Unexpected url") |
Contributor
There was a problem hiding this comment.
The "unexpected url" message is unnecessary (also below).
| // Also, make sure that the redirect url contains the query string present in the request. | ||
| val requestURI = req.getRequestURI + Option(req.getQueryString).map("?" + _).getOrElse("") | ||
| val attemptPart = if (shouldAppendAttemptId) { | ||
| if (!req.getRequestURI.endsWith("/")) { |
Contributor
There was a problem hiding this comment.
Simpler:
val redirect = if (shouldAppendAttemptId) {
req.getRequestURI().stripSuffix("/") + "/" + attemptId.get
} else {
req.getRequestURI()
}
val query = Option(req.getQueryString).map("?" + _).getOrElse("")
res.sendRedirect(...)
|
Test build #108410 has finished for PR 25301 at commit
|
|
Test build #108442 has finished for PR 25301 at commit
|
Contributor
|
Merging to master, will try 2.4. |
vanzin
pushed a commit
that referenced
this pull request
Jul 31, 2019
…ttempt id ## What changes were proposed in this pull request? When we set ```spark.history.ui.maxApplications``` to a small value, we can't get some apps from the page search. If the url is spliced (http://localhost:18080/history/local-xxx), it can be accessed if the app has no attempt. But in the case of multiple attempted apps, such a url cannot be accessed, and the page displays Not Found. ## How was this patch tested? Add UT Closes #25301 from cxzl25/hs_app_last_attempt_id. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit 70ef906) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
rluta
pushed a commit
to rluta/spark
that referenced
this pull request
Sep 17, 2019
…ttempt id ## What changes were proposed in this pull request? When we set ```spark.history.ui.maxApplications``` to a small value, we can't get some apps from the page search. If the url is spliced (http://localhost:18080/history/local-xxx), it can be accessed if the app has no attempt. But in the case of multiple attempted apps, such a url cannot be accessed, and the page displays Not Found. ## How was this patch tested? Add UT Closes apache#25301 from cxzl25/hs_app_last_attempt_id. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit 70ef906) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Sep 26, 2019
…ttempt id ## What changes were proposed in this pull request? When we set ```spark.history.ui.maxApplications``` to a small value, we can't get some apps from the page search. If the url is spliced (http://localhost:18080/history/local-xxx), it can be accessed if the app has no attempt. But in the case of multiple attempted apps, such a url cannot be accessed, and the page displays Not Found. ## How was this patch tested? Add UT Closes apache#25301 from cxzl25/hs_app_last_attempt_id. Authored-by: sychen <sychen@ctrip.com> Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com> (cherry picked from commit 70ef906) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When we set
spark.history.ui.maxApplicationsto a small value, we can't get some apps from the page search.If the url is spliced (http://localhost:18080/history/local-xxx), it can be accessed if the app has no attempt.
But in the case of multiple attempted apps, such a url cannot be accessed, and the page displays Not Found.
How was this patch tested?
Add UT