Skip to content

Conversation

@harishreedharan
Copy link
Contributor

...ing for the channel size.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have started for PR 2531 at commit 6ce9d8b.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have finished for PR 2531 at commit 6ce9d8b.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20778/

@harishreedharan
Copy link
Contributor Author

Jenkins, test this please

Thanks,
Hari

On Wed, Sep 24, 2014 at 9:57 PM, UCB AMPLab notifications@github.com
wrote:

Test PASSed.
Refer to this link for build results (access rights to CI server needed):

https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20778/

Reply to this email directly or view it on GitHub:
#2531 (comment)

@harishreedharan
Copy link
Contributor Author

Jenkins, test this please

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have started for PR 2531 at commit 6ce9d8b.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor

Hey @harishreedharan - because the Spark tests take a long time, we don't usually allow sleep statements. Is there a way to use some better synchronization to make this test pass deterministically?

@harishreedharan
Copy link
Contributor Author

Let me see if I can add a method in the sink that can be used to query if the acks have come.

@pwendell
Copy link
Contributor

That would be great. If you really need to rely on sleeps then it would be good to at least sleep in several smaller intervals rather than 1 second and check multiple times. But we've tried to have all our tests use proper synchronization to avoid this.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have finished for PR 2531 at commit 6ce9d8b.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20780/

@harishreedharan
Copy link
Contributor Author

This is more deterministic. This counts down when a batch is completed.

@harishreedharan
Copy link
Contributor Author

Jenkins, test this please

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have started for PR 2531 at commit 30393c1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have started for PR 2531 at commit 30393c1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have finished for PR 2531 at commit 30393c1.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20820/

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have finished for PR 2531 at commit 30393c1.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20821/

@harishreedharan
Copy link
Contributor Author

Jenkins, test this please

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have started for PR 2531 at commit 30393c1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 25, 2014

QA tests have finished for PR 2531 at commit 30393c1.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20823/

@harishreedharan
Copy link
Contributor Author

Jenkins, test this please

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have started for PR 2531 at commit 30393c1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have finished for PR 2531 at commit 30393c1.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20837/

@harishreedharan
Copy link
Contributor Author

@pwendell This seems to be stable at this point.

@pwendell
Copy link
Contributor

Thanks Hari - I'll pull it in.

@asfgit asfgit closed this in b235e01 Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants