-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3686][STREAMING] Wait for sink to commit the channel before check... #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ecking for the channel size.
|
QA tests have started for PR 2531 at commit
|
|
QA tests have finished for PR 2531 at commit
|
|
Test PASSed. |
|
Jenkins, test this please Thanks, On Wed, Sep 24, 2014 at 9:57 PM, UCB AMPLab notifications@github.com
|
|
Jenkins, test this please |
|
QA tests have started for PR 2531 at commit
|
|
Hey @harishreedharan - because the Spark tests take a long time, we don't usually allow sleep statements. Is there a way to use some better synchronization to make this test pass deterministically? |
|
Let me see if I can add a method in the sink that can be used to query if the acks have come. |
|
That would be great. If you really need to rely on sleeps then it would be good to at least sleep in several smaller intervals rather than 1 second and check multiple times. But we've tried to have all our tests use proper synchronization to avoid this. |
|
QA tests have finished for PR 2531 at commit
|
|
Test PASSed. |
|
This is more deterministic. This counts down when a batch is completed. |
|
Jenkins, test this please |
|
QA tests have started for PR 2531 at commit
|
|
QA tests have started for PR 2531 at commit
|
|
QA tests have finished for PR 2531 at commit
|
|
Test PASSed. |
|
QA tests have finished for PR 2531 at commit
|
|
Test PASSed. |
|
Jenkins, test this please |
|
QA tests have started for PR 2531 at commit
|
|
QA tests have finished for PR 2531 at commit
|
|
Test PASSed. |
|
Jenkins, test this please |
|
QA tests have started for PR 2531 at commit
|
|
QA tests have finished for PR 2531 at commit
|
|
Test PASSed. |
|
@pwendell This seems to be stable at this point. |
|
Thanks Hari - I'll pull it in. |
...ing for the channel size.