Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to make Javadoc in org.apache.spark.shuffle.api visible.

How was this patch tested?

Manually built the doc and checked:

Screen Shot 2019-08-01 at 4 48 23 PM

@HyukjinKwon
Copy link
Member Author

@mccheah, @vanzin, @squito, @jerryshao, I happened to take a look at the JIRA. The doc will be visible with this change and able to verify the doc output.

@SparkQA
Copy link

SparkQA commented Aug 1, 2019

Test build #108509 has finished for PR 25323 at commit 4233dfa.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

@squito squito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.
Thank you, @HyukjinKwon , @squito , @srowen , @mccheah !

@HyukjinKwon HyukjinKwon deleted the SPARK-28568 branch March 3, 2020 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants