Skip to content

Conversation

@jzhuge
Copy link
Member

@jzhuge jzhuge commented Aug 4, 2019

What changes were proposed in this pull request?

  • DataFrameWriter.insertInto should match column names by position.
  • Clean up test cases.

How was this patch tested?

New tests:

  • insertInto: append by position
  • insertInto: overwrite partitioned table in static mode by position
  • insertInto: overwrite partitioned table in dynamic mode by position

Match column names by position.
Clean up test cases.
@SparkQA
Copy link

SparkQA commented Aug 4, 2019

Test build #108629 has finished for PR 25353 at commit 7313f1e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28178][SQL][HOTFIX] DataSourceV2: DataFrameWriter.insertInfo [SPARK-28178][SQL] DataSourceV2: DataFrameWriter.insertInfo Aug 5, 2019
@dongjoon-hyun
Copy link
Member

Hi, @jzhuge . HOTFIX is used when the branch is broken and all the PR builders are failed due to that.

@cloud-fan cloud-fan changed the title [SPARK-28178][SQL] DataSourceV2: DataFrameWriter.insertInfo [SPARK-28178][SQL][followup] DataSourceV2: DataFrameWriter.insertInfo Aug 5, 2019
@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in cae500a Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants