[SPARK-27637][Shuffle][FOLLOW-UP]For nettyBlockTransferService, if IOException occurred while create client, check whether relative executor is alive before retry #24533 #25469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
gentle ping @cloud-fan @felixcheung |
Contributor
|
ok to test |
cloud-fan
approved these changes
Aug 16, 2019
|
Test build #109174 has finished for PR 25469 at commit
|
Contributor
Author
|
@cloud-fan strange test result of Unit test. The shown failed Unit test can be run correctly in my computer |
Member
|
retest this please |
Member
|
@AngersZhuuuu ok, the other prs hit the same errors, so they are not related to this pr. |
Contributor
Author
Got it, thanks. |
|
Test build #109183 has finished for PR 25469 at commit
|
Contributor
Author
|
@maropu passed test but seem failed due to some strange reason |
Contributor
|
retest this please |
dongjoon-hyun
changed the title
|
Test build #109199 has finished for PR 25469 at commit
|
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In pr #24533 , it prevent retry to a removed Executor.
In my test, I can't catch exceptions from
new OneForOneBlockFetcher(client, appId, execId, blockIds, listener, transportConf, tempFileManager).start()And I check the code carefully， method start() will handle exception of IOException in it's retry logical, won't throw it out. until it meet maxRetry times or meet exception that is not IOException.
And if we meet the situation that when we fetch block , the executor is dead, when we rerun
RetryingBlockFetcher.BlockFetchStarter.createAndStart()we may failed when we create a transport client to dead executor. it will throw a IOException.
We should catch this IOException.
Why are the changes needed?
Old solution not comprehensive. Didn't cover more case.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existed Unit Test